[Semsdev] AmSipDialog::refer function with expires

[Balint Kovacs]

Hi,

I think the newline is necessary.
Without the newline the headers seems like this:

Contact: <sip:1010 at 10.10.10.10:5060>
Refer-To: sip:1111 at 11.11.11.11:5060Max-Forwards: 70
Content-Length: 0

So, yes it is a bug currently.



I extended the IVR plugin for sending BYE with headers.

Index: IvrDialogBase.cpp
===================================================================
--- IvrDialogBase.cpp    (revision 1354)
+++ IvrDialogBase.cpp    (working copy)
@@ -182,12 +182,18 @@
   return Py_None;
 }
 
-static PyObject* IvrDialogBase_bye(IvrDialogBase* self, PyObject*)
+static PyObject* IvrDialogBase_bye(IvrDialogBase* self, PyObject* args)
 {
+  char* hdrs=0;
+
   assert(self->p_dlg);
-  self->p_dlg->dlg.bye();
+  if(!PyArg_ParseTuple(args,"s", &hdrs))
+    return NULL;
+
+  self->p_dlg->dlg.bye(hdrs);
   Py_INCREF(Py_None);
   return Py_None;
+ 
 }
 
 //




Stefan Sayer wrote:
> Hello,
>
> how about the trailing newline? your patch adds a \n in both cases. Is 
> that a bug currently?
>
> Thanks
> Stefan
>


-- 
  	Balint Kovacs
Software Engineer
Gamma Telecom
Mobile 	+36 (06) 70 244 6677
Phone 	+44 (0) 207 078 8213
Email 	bkovacs at gammatelecom.com <mailto:bkovacs at gammatelecom.com>
Web 	www.gammatelecom.com <http://www.gammatelecom.com>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.iptel.org/pipermail/semsdev/attachments/20090519/82a564c7/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mobile.jpg
Type: image/jpeg
Size: 4063 bytes
Desc: not available
URL: <http://lists.iptel.org/pipermail/semsdev/attachments/20090519/82a564c7/attachment-0005.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: phone.jpg
Type: image/jpeg
Size: 4099 bytes
Desc: not available
URL: <http://lists.iptel.org/pipermail/semsdev/attachments/20090519/82a564c7/attachment-0006.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: email.jpg
Type: image/jpeg
Size: 4003 bytes
Desc: not available
URL: <http://lists.iptel.org/pipermail/semsdev/attachments/20090519/82a564c7/attachment-0007.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: web.jpg
Type: image/jpeg
Size: 4112 bytes
Desc: not available
URL: <http://lists.iptel.org/pipermail/semsdev/attachments/20090519/82a564c7/attachment-0008.jpg>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: footer.jpg
Type: image/jpeg
Size: 9212 bytes
Desc: not available
URL: <http://lists.iptel.org/pipermail/semsdev/attachments/20090519/82a564c7/attachment-0009.jpg>